Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update / rename lifecycle events of deploy plugin #1577

Closed
2 tasks done
pmuens opened this issue Jul 15, 2016 · 6 comments
Closed
2 tasks done

Update / rename lifecycle events of deploy plugin #1577

pmuens opened this issue Jul 15, 2016 · 6 comments
Assignees
Milestone

Comments

@pmuens
Copy link
Contributor

pmuens commented Jul 15, 2016

The lifecycleEvents of the deployplugins should be renamed to be less specific but more broadly defined so that the naming will "work" for all providers.

  • Update docs
  • Update all plugins which uses those lifecycles
@pmuens pmuens added this to the v1.0 milestone Jul 15, 2016
@pmuens pmuens self-assigned this Jul 15, 2016
@flomotlik flomotlik modified the milestones: v1.0.0-beta.2, v1.0 Aug 5, 2016
@flomotlik
Copy link
Contributor

Imho we should do that in the next beta release, so its all prepared before the full release. Should be easy to do anyway.

@pmuens
Copy link
Contributor Author

pmuens commented Aug 5, 2016

Yep. Good idea. Maybe we should also evaluate other providers before doing that...

@flomotlik
Copy link
Contributor

Imho that would be a lot of guesswork as we don't really know where providers are going and what is necessary. If we take the current lifecycle events and make them a bit more generic maybe we should be in a good place imho.

@pmuens pmuens added the feedback label Aug 8, 2016
@pmuens
Copy link
Contributor Author

pmuens commented Aug 8, 2016

This are the lifecycle events we currently have:

'initializeResources',
'createProviderStacks',
'createDeploymentPackage',
'compileFunctions',
'compileEvents',
'deploy',

IMHO we can keep most of them. Anyway here are my proposals for name changes:

'initializeResources', --> 'initialize'
'createProviderStacks', --> 'setupProviderConfiguration'
'createDeploymentPackage', --> 'createDeploymentArtifacts'
'compileFunctions',
'compileEvents',
'deploy',

/cc @flomotlik @eahefnawy

@pmuens pmuens removed the feedback label Aug 10, 2016
@flomotlik
Copy link
Contributor

looks good @pmuens . If you could create a PR that can go out

@pmuens
Copy link
Contributor Author

pmuens commented Aug 11, 2016

Done with #1824

@pmuens pmuens closed this as completed Aug 11, 2016
@pmuens pmuens changed the title Update / rename lifecycleEvents of deploy plugin Update / rename lifecycle events of deploy plugin Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants