Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access-Control-Allow-Credentials for CORS settings #2182

Closed
TaichiHo opened this issue Sep 21, 2016 · 5 comments · Fixed by #2736
Closed

Add Access-Control-Allow-Credentials for CORS settings #2182

TaichiHo opened this issue Sep 21, 2016 · 5 comments · Fixed by #2736

Comments

@TaichiHo
Copy link

This is a Feature Proposal

Description

Right now I am developing a cross origin resource sharing (CORS) application which requires sharing cookies. The server is required to return the Access-Control-Allow-Credentials header set to true to allow this. While there is way to set headers, methods and origins with serverless, there is no easy way of setting the allow-credentials header. Will have to go to aws console to enable this which is a headache for maintenance.

Similar or dependent issues:

Additional Data

  • _Serverless Framework Version you're using_:
  • _Operating System_:
  • _Stack Trace_:
  • _Provider Error messages_:
@IIapad0ks
Copy link

@str3tch
Copy link

str3tch commented Oct 6, 2016

+1, is there a fix for this anywhere?

@fruffin
Copy link
Contributor

fruffin commented Oct 11, 2016

I needed that as well and now have an experimental version working for me.
I'll polish it a bit, write the tests and start the PR

@str3tch
Copy link

str3tch commented Oct 11, 2016

ha, I also have a rough and ready version too. need to polish it a lot, so you might beat me to it. Will be good to compare approaches

@fruffin
Copy link
Contributor

fruffin commented Oct 16, 2016

Ready for review
Works on my machine! ;-)

asprouse added a commit to asprouse/serverless that referenced this issue Dec 5, 2016
@pmuens pmuens removed the exp/medium label Jan 4, 2017
eahefnawy added a commit that referenced this issue Jan 26, 2017
Added Access-Control-Allow-Credentials for CORS settings fixes #2182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants