Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new analytics and notifications service #7811

Merged
merged 11 commits into from
Jun 16, 2020

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 3, 2020

Depends on serverless/utils#53 which needs to be merged first (and v1.0.0 of @serverless/utils been published) (Done)

  • Remove old analytics endpoints
  • Rename tracking to analytics (as it's actually about gathering analytics and not tracking users)
  • Configure new analytics endpoint and send report only on service deployments
  • Process and intelligently (unobtrusively) display a notification as propagated from backend service
  • Replace internal lib/utils/config with @serverless/utils/config

@medikoo medikoo self-assigned this Jun 3, 2020
@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch 3 times, most recently from 0c9bd6a to 3ba9bac Compare June 3, 2020 14:18
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #7811 into master will increase coverage by 0.25%.
The diff coverage is 86.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7811      +/-   ##
==========================================
+ Coverage   88.22%   88.48%   +0.25%     
==========================================
  Files         245      243       -2     
  Lines        9306     9028     -278     
==========================================
- Hits         8210     7988     -222     
+ Misses       1096     1040      -56     
Impacted Files Coverage Δ
lib/Serverless.js 100.00% <ø> (ø)
lib/plugins/aws/lib/validate.js 100.00% <ø> (ø)
lib/plugins/aws/provider/awsProvider.js 92.66% <ø> (-0.06%) ⬇️
lib/plugins/config/config.js 88.88% <ø> (-0.91%) ⬇️
lib/plugins/create/create.js 90.80% <ø> (-0.31%) ⬇️
lib/plugins/info/info.js 100.00% <ø> (+22.22%) ⬆️
lib/plugins/install/install.js 100.00% <ø> (ø)
lib/plugins/invoke/invoke.js 77.77% <ø> (+6.34%) ⬆️
lib/plugins/logs/logs.js 100.00% <ø> (+7.14%) ⬆️
lib/plugins/metrics/metrics.js 100.00% <ø> (+30.00%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a549517...585f283. Read the comment docs.

@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch 2 times, most recently from c10db9a to b7ec31e Compare June 10, 2020 06:26
@hkbarton
Copy link
Contributor

@medikoo can we merge this now?

@medikoo
Copy link
Contributor Author

medikoo commented Jun 12, 2020

@medikoo can we merge this now?

I'm moving some of the functionality to common util, so it can be used also in v1 and v2. It should be ready today. Then we'll merge it

@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch from b7ec31e to cff78b8 Compare June 12, 2020 14:33
@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch 3 times, most recently from adfe7d1 to c52c85f Compare June 15, 2020 11:17
@medikoo
Copy link
Contributor Author

medikoo commented Jun 15, 2020

@hkbarton it's ready for review and merge

@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch 2 times, most recently from c2e8957 to e557b27 Compare June 16, 2020 06:44
@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch from e557b27 to c387105 Compare June 16, 2020 08:39
@medikoo medikoo force-pushed the 0601-support-monitoring-and-notifications-service branch from c387105 to 585f283 Compare June 16, 2020 08:52
@medikoo medikoo merged commit 49b5914 into master Jun 16, 2020
@medikoo medikoo deleted the 0601-support-monitoring-and-notifications-service branch June 16, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants