Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from top-level lib/plugins #8973

Merged
merged 1 commit into from Feb 22, 2021

Conversation

juanjoDiaz
Copy link
Contributor

…older

Addresses: #7171

I can keep adding the rest of the folders under lib/plugins since I sort of have them. Just need to review then.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #8973 (adb697b) into master (1a694ae) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8973   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         268      268           
  Lines       10045    10037    -8     
=======================================
- Hits         8808     8801    -7     
+ Misses       1237     1236    -1     
Impacted Files Coverage Δ
lib/plugins/invoke.js 94.44% <ø> (+3.53%) ⬆️
lib/plugins/config.js 80.55% <77.27%> (-0.78%) ⬇️
lib/plugins/deploy.js 100.00% <100.00%> (ø)
lib/plugins/install.js 100.00% <100.00%> (ø)
lib/plugins/print.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a694ae...d658c6d. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @juanjoDiaz - well done 👍

@pgrzesik pgrzesik changed the title refactor: Remove bluebird from top-level modules of lib/plugins f… refactor: Remove bluebird from top-level lib/plugins Feb 22, 2021
@pgrzesik pgrzesik merged commit 8fead7f into serverless:master Feb 22, 2021
@juanjoDiaz juanjoDiaz deleted the remove_bluebird_plugins_top branch February 24, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants