Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert recent refactorings of bluebird #9074

Merged
merged 8 commits into from Mar 4, 2021
Merged

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Mar 4, 2021

Reverts #9054, #9029, #9028, #8996, #8984, #8973, #8972, #8943

With a heavy heart, due to a few regressions introduced with recent Bluebird refactorings, we've decided to revert a few of the recent PRs with such refactorings and put on pause bigger changes related to Bluebird migration. Unfortunately, it's very easy to miss things during the review process of such refactors, some of the changes are also not caught by our test suite and we want to be more careful moving forward. We'd like to follow the process outlined in #7171 to limit the potential impacts and unexpected regressions for Framework users.

Potentially fixes #9073

@pgrzesik pgrzesik self-assigned this Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #9074 (1ae0588) into master (ccba70a) will increase coverage by 0.01%.
The diff coverage is 94.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9074      +/-   ##
==========================================
+ Coverage   87.15%   87.17%   +0.01%     
==========================================
  Files         288      288              
  Lines       11026    11068      +42     
==========================================
+ Hits         9610     9648      +38     
- Misses       1416     1420       +4     
Impacted Files Coverage Δ
lib/utils/open.js 13.58% <66.66%> (ø)
lib/plugins/invoke.js 90.90% <75.00%> (-3.54%) ⬇️
lib/utils/createFromTemplate.js 83.33% <77.27%> (-11.67%) ⬇️
lib/plugins/config.js 81.33% <80.00%> (+0.77%) ⬆️
lib/plugins/aws/utils/credentials.js 91.93% <83.87%> (-2.51%) ⬇️
lib/plugins/create/create.js 90.69% <86.36%> (+0.69%) ⬆️
lib/plugins/aws/provider.js 95.10% <86.48%> (-0.04%) ⬇️
lib/plugins/package/lib/zipService.js 96.29% <93.65%> (-0.93%) ⬇️
lib/utils/yamlAstParser.js 97.32% <94.82%> (-0.87%) ⬇️
lib/plugins/interactiveCli/tabCompletion.js 97.50% <96.29%> (+0.20%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccba70a...53324d0. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @pgrzesik !

Not investigating the changeset as I assume all was automatic reverts

@pgrzesik pgrzesik merged commit 55abaaf into master Mar 4, 2021
@pgrzesik pgrzesik deleted the revert-bluebird-refactors branch March 4, 2021 10:06
@Ksmike
Copy link

Ksmike commented Mar 4, 2021

Great thanks @pgrzesik !

Not investigating the changeset as I assume all was automatic reverts

What version is this pinned too?

@pgrzesik
Copy link
Contributor Author

pgrzesik commented Mar 4, 2021

@Ksmike It's going to be released soon as 2.28.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: EMFILE: too many open files
3 participants