New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert recent refactorings of bluebird
#9074
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9074 +/- ##
==========================================
+ Coverage 87.15% 87.17% +0.01%
==========================================
Files 288 288
Lines 11026 11068 +42
==========================================
+ Hits 9610 9648 +38
- Misses 1416 1420 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks @pgrzesik !
Not investigating the changeset as I assume all was automatic reverts
What version is this pinned too? |
@Ksmike It's going to be released soon as |
Reverts #9054, #9029, #9028, #8996, #8984, #8973, #8972, #8943
With a heavy heart, due to a few regressions introduced with recent Bluebird refactorings, we've decided to revert a few of the recent PRs with such refactorings and put on pause bigger changes related to
Bluebird
migration. Unfortunately, it's very easy to miss things during the review process of such refactors, some of the changes are also not caught by our test suite and we want to be more careful moving forward. We'd like to follow the process outlined in #7171 to limit the potential impacts and unexpected regressions for Framework users.Potentially fixes #9073