Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: Make scope name format more strict #9289

Open
medikoo opened this issue Apr 12, 2021 · 0 comments
Open

Variables: Make scope name format more strict #9289

medikoo opened this issue Apr 12, 2021 · 0 comments

Comments

@medikoo
Copy link
Contributor

medikoo commented Apr 12, 2021

Use case description

Currently allowed scope name format is relaxed to e.g. support . or -. To it's properly gather notation as cf.us-east-1:foo.

Still this scope name notation is already deprecated, and even scopes with such named are not really resolved by new resolver (resolution is then fallback to old resolver).

Scope name format is constructed that way to fully detect all variables written in old notation (so we have full information needed to decided whether old resolver should be invoked or not).

Currently supporting such extended format introduced side effect, as in some cases we catch AWS vars as Serverless Vars, as reported here: https://forum.serverless.com/t/brave-new-variable-resolver-world/14704

With next major we don't have to do that, and we can narrow supported format to [a-z][a-zA-Z0-9.]*. (I'd still keep support for . to allow providing solutions as e.g. proposed here: #5202)

Proposed solution

Update supported format to [a-z][a-zA-Z0-9.]*

@medikoo medikoo added this to the v3 milestone Apr 12, 2021
@austencollins austencollins removed this from the v3 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants