Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sls package --aws-s3-accelerate #9812

Open
JamesKyburz opened this issue Aug 6, 2021 · 6 comments
Open

sls package --aws-s3-accelerate #9812

JamesKyburz opened this issue Aug 6, 2021 · 6 comments

Comments

@JamesKyburz
Copy link
Contributor

Using version 2.53.0

When executing sls package --aws-s3-accelerate we get an incorrect deprecation warning.

Serverless: Packaging service...
Serverless: Deprecation warning: Detected unrecognized CLI options: "--aws-s3-accelerate".

However the cloudformation output contains the correct s3 bucket configuration.

"AccelerateConfiguration": {
  "AccelerationStatus": "Enabled"
}

If the option is removed from the package command prior to a deploy it fails.

sls package
sls deploy --package .serverless --aws-s3-accelerate
 Serverless Error ----------------------------------------
 
  S3 Transfer Acceleration is not configured on this bucket

Installed version

2.53.0
@JamesKyburz
Copy link
Contributor Author

Am happy to submit a PR but was not sure if the code should be added to the lib/cli/commands-schema/aws-service.js

@pgrzesik
Copy link
Contributor

pgrzesik commented Aug 6, 2021

Hello @JamesKyburz, thanks for reporting. It looks like that option was ommitted when options schema was introduces and yes, it should be added to the module you've linked. We'd be more than happy to accept a PR 🙇

JamesKyburz added a commit to JamesKyburz/serverless that referenced this issue Aug 6, 2021
@JamesKyburz
Copy link
Contributor Author

Thanks, will send a PR.

@JamesKyburz
Copy link
Contributor Author

Sent a simple PR and have verified it works locally with npm link.

@JamesKyburz
Copy link
Contributor Author

with v3 package fails with --aws-s3-accelerate, and deploy fails with --aws-s3-accelerate if package hasn't configured the bucket with accelerate.

@pgrzesik
Copy link
Contributor

@JamesKyburz could you provide the repro steps? There was a change from warn to error in some of such cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants