-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CLI): Modern logs for slstats
command
#10036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10036 +/- ##
==========================================
- Coverage 85.88% 85.76% -0.13%
==========================================
Files 333 333
Lines 13416 13427 +11
==========================================
- Hits 11523 11515 -8
- Misses 1893 1912 +19
Continue to review full report at Codecov.
|
lib/plugins/slstats.js
Outdated
@@ -25,11 +26,15 @@ class SlStats { | |||
if (enableStats) { | |||
// set .serverlessrc config | |||
config.set('trackingDisabled', false); | |||
this.serverless.cli.log('Stats successfully enabled'); | |||
const message = 'Stats successfully enabled'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, here, let's not create variables to be ditched in v3 branch
24a70d1
to
1ad9cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Addresses: #9860