Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Modern logs adjustements for logs and info commands #10037

Merged
merged 5 commits into from Oct 1, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 1, 2021

Addresses: #9860

Additionally improved error reporting (issue reported internally)

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #10037 (cf1fb30) into master (f73062f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10037   +/-   ##
=======================================
  Coverage   85.88%   85.89%           
=======================================
  Files         333      333           
  Lines       13416    13418    +2     
=======================================
+ Hits        11523    11525    +2     
  Misses       1893     1893           
Impacted Files Coverage Δ
lib/cli/write-service-outputs.js 83.33% <ø> (-2.39%) ⬇️
lib/cli/handle-error.js 85.71% <100.00%> (-0.29%) ⬇️
lib/plugins/aws/deploy/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/info/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/logs.js 87.71% <100.00%> (-0.42%) ⬇️
lib/plugins/aws/utils/formatLambdaLogEvent.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73062f...cf1fb30. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik October 1, 2021 11:23
@medikoo medikoo force-pushed the 1001-modern-logs-adjustements branch from 9468c7d to cf1fb30 Compare October 1, 2021 13:16
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@medikoo medikoo merged commit a205f88 into master Oct 1, 2021
@medikoo medikoo deleted the 1001-modern-logs-adjustements branch October 1, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants