Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix resolution of handler in case of local fallback #10042

Merged
merged 1 commit into from Oct 1, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 1, 2021

Closes: #10039

@medikoo medikoo self-assigned this Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #10042 (1d1369b) into master (a205f88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10042   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         333      333           
  Lines       13418    13418           
=======================================
  Hits        11525    11525           
  Misses       1893     1893           
Impacted Files Coverage Δ
lib/cli/handle-error.js 85.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a205f88...1d1369b. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik October 1, 2021 14:26
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 7d31410 into master Oct 1, 2021
@medikoo medikoo deleted the 1001-fix-error-handle branch October 1, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localErrorHandlerData.handle is not a function
2 participants