New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(CLI): Modern logs for invoke
command
#10052
Conversation
chalk.gray('--------------------------------------------------------------------') | ||
); | ||
writeText( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided to keep this separator in similar manner as it was in previous implementation
logResult.split('\n').forEach((line) => this.consoleLog(formatLambdaLogEvent(line))); | ||
logResult.split('\n').forEach((line) => { | ||
legacy.consoleLog(formatLambdaLogEvent(line)); | ||
writeText(formatLambdaLogEvent(line, { isModern: true })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided to follow the same formatting as sls logs
uses here
Codecov Report
@@ Coverage Diff @@
## master #10052 +/- ##
=======================================
Coverage 85.75% 85.76%
=======================================
Files 333 333
Lines 13435 13443 +8
=======================================
+ Hits 11521 11529 +8
Misses 1914 1914
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Addresses: #9860