Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Deploy: Fix deprecation placement #10111

Merged
merged 2 commits into from Oct 18, 2021
Merged

AWS Deploy: Fix deprecation placement #10111

merged 2 commits into from Oct 18, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 18, 2021

Two minor patches:

  • Fix deprecation placement. It was presented only when packaging was involved, while it should have been displayed in any deployment case
  • Improve style for local fallback modern logs notice

@medikoo medikoo self-assigned this Oct 18, 2021
@medikoo medikoo changed the title 1018 minor fixes AWS Deploy: Fix deprecation placement Oct 18, 2021
@medikoo medikoo requested a review from pgrzesik October 18, 2021 15:30
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #10111 (0d0bc8c) into master (ff4072b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10111   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         334      334           
  Lines       13638    13638           
=======================================
  Hits        11628    11628           
  Misses       2010     2010           
Impacted Files Coverage Δ
lib/Serverless.js 69.46% <100.00%> (ø)
lib/plugins/aws/package/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4072b...0d0bc8c. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👍

@medikoo medikoo merged commit 73c071b into master Oct 18, 2021
@medikoo medikoo deleted the 1018-minor-fixes branch October 18, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants