Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Remove optional tab autocompletion feature #10414

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 23, 2021

Reasoning:

  • Performance is very poor due to slow command startup time
  • tabtab package is no longer maintained and shares security issues
  • Feature usage is relatively low (telemetry data shows 7% of users has the autocompletion on)

Closes: #8473

Addresses #10182

Reasoning:
- Performance is very poor due to slow command startup time
- `tabtab` package is no longer maintained and shares security issues
- Feature usage is relatively low (telemetry data shows 7% of users has the autocompletion on)

BREAKING CHANGE:
Opt-in tab-tab autocompletion feature is removed due to performance and security issues
@medikoo medikoo self-assigned this Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #10414 (4c25f91) into v3 (22b6de5) will increase coverage by 0.25%.
The diff coverage is n/a.

❗ Current head 4c25f91 differs from pull request most recent head 0b12363. Consider uploading reports for the commit 0b12363 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##               v3   #10414      +/-   ##
==========================================
+ Coverage   83.14%   83.40%   +0.25%     
==========================================
  Files         346      339       -7     
  Lines       14115    13978     -137     
==========================================
- Hits        11736    11658      -78     
+ Misses       2379     2320      -59     
Impacted Files Coverage Δ
lib/Serverless.js 66.66% <ø> (-0.16%) ⬇️
lib/classes/PluginManager.js 91.12% <ø> (-0.43%) ⬇️
lib/cli/commands-schema/no-service.js 100.00% <ø> (ø)
lib/plugins/config.js 69.38% <ø> (-6.23%) ⬇️
lib/utils/telemetry/generatePayload.js 91.20% <ø> (+0.29%) ⬆️
scripts/serverless.js 57.62% <ø> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b6de5...0b12363. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good call 👍

@medikoo medikoo merged commit 979668c into v3 Dec 23, 2021
@medikoo medikoo deleted the 1223-drop-tab-tab-completion branch December 23, 2021 13:26
@mnapoli
Copy link
Contributor

mnapoli commented Dec 23, 2021

Should we also delete this documentation page: https://www.serverless.com/framework/docs/providers/aws/cli-reference/config-tabcompletion ?

@medikoo
Copy link
Contributor Author

medikoo commented Dec 23, 2021

Should we also delete this documentation page: https://www.serverless.com/framework/docs/providers/aws/cli-reference/config-tabcompletion ?

Ouch, indeed I missed that. I've fixed it and updated merged commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants