Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Telemetry): Rely on direct evaluation of isTtyTerminal #10786

Merged
merged 1 commit into from Mar 2, 2022

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Mar 2, 2022

After upgrade to isInteractive logic in serverless/utils, we should not rely on that for isTtyTerminal as it might have false negatives in CI environments.

@pgrzesik pgrzesik self-assigned this Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #10786 (2a17c14) into main (21c783d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10786      +/-   ##
==========================================
- Coverage   86.38%   86.38%   -0.01%     
==========================================
  Files         304      304              
  Lines       12717    12716       -1     
==========================================
- Hits        10986    10985       -1     
  Misses       1731     1731              
Impacted Files Coverage Δ
lib/utils/telemetry/generate-payload.js 92.24% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c783d...2a17c14. Read the comment docs.

@pgrzesik pgrzesik merged commit e29253f into main Mar 2, 2022
@pgrzesik pgrzesik deleted the rely-on-proper-is-tty-resolution branch March 2, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant