Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: Interactive CLI improvements #10825

Merged
merged 21 commits into from Mar 9, 2022
Merged

Console: Interactive CLI improvements #10825

merged 21 commits into from Mar 9, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Mar 9, 2022

  • Support joint Console & Dashboard integrations
  • Do not list not supported by Console services when Console integration is to be setup
  • Fix discovered logic bugs
  • Introduce additional isConsoleEnabled property for initialContext

@medikoo medikoo requested a review from pgrzesik March 9, 2022 16:10
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #10825 (6bec216) into main (8ddba63) will increase coverage by 0.00%.
The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10825   +/-   ##
=======================================
  Coverage   86.38%   86.39%           
=======================================
  Files         304      304           
  Lines       12717    12743   +26     
=======================================
+ Hits        10986    11009   +23     
- Misses       1731     1734    +3     
Impacted Files Coverage Δ
lib/classes/console.js 82.75% <ø> (-0.24%) ⬇️
lib/utils/telemetry/generate-payload.js 92.24% <ø> (ø)
lib/cli/interactive-setup/utils.js 86.56% <88.23%> (+0.60%) ⬆️
lib/cli/interactive-setup/dashboard-set-org.js 88.38% <94.44%> (-0.15%) ⬇️
lib/cli/interactive-setup/dashboard-login.js 87.50% <100.00%> (ø)
lib/cli/interactive-setup/index.js 90.62% <100.00%> (+0.62%) ⬆️
lib/cli/interactive-setup/service.js 98.27% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ddba63...6bec216. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I only have a few minor questions

lib/utils/telemetry/generate-payload.js Show resolved Hide resolved
lib/cli/interactive-setup/service.js Show resolved Hide resolved
lib/cli/interactive-setup/dashboard-login.js Show resolved Hide resolved
lib/cli/interactive-setup/utils.js Show resolved Hide resolved
@medikoo medikoo requested a review from pgrzesik March 9, 2022 16:28
@medikoo medikoo merged commit 3b3ccb0 into main Mar 9, 2022
@medikoo medikoo deleted the 0308-console-improvements branch March 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants