fix(AWS Kafka): Allow usage of Server Root CA without client TLS auth #10837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10837 +/- ##
==========================================
- Coverage 86.39% 86.39% -0.01%
==========================================
Files 304 304
Lines 12743 12741 -2
==========================================
- Hits 11009 11007 -2
Misses 1734 1734
Continue to review full report at Codecov.
|
pgrzesik
changed the title
pgrzesik
reviewed
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a check that prevented us from using a Kafka server root ca cert without using TLS client auth.
The check was previously implemented based on wrong assumptions. The two certs are actually independent from each other.
Addresses: #10260