Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: Dynamically resolve latest version of the extension #10842

Merged
merged 2 commits into from Mar 14, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Mar 11, 2022

Instead of relying on layer extension packaged as installed with regular npm install, at every packaging step ensure to resolve the latest version from npm.

This will allow users to not run npm update to get the latest version of the layer

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #10842 (2506b56) into main (6a6417c) will increase coverage by 0.01%.
The diff coverage is 90.47%.

❗ Current head 2506b56 differs from pull request most recent head 10607fe. Consider uploading reports for the commit 10607fe to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10842      +/-   ##
==========================================
+ Coverage   86.39%   86.40%   +0.01%     
==========================================
  Files         304      304              
  Lines       12741    12770      +29     
==========================================
+ Hits        11007    11034      +27     
- Misses       1734     1736       +2     
Impacted Files Coverage Δ
lib/plugins/aws/package/lib/save-service-state.js 100.00% <ø> (ø)
lib/utils/telemetry/generate-payload.js 92.24% <ø> (ø)
scripts/pkg/config.js 0.00% <ø> (ø)
lib/classes/console.js 84.21% <89.18%> (+1.45%) ⬆️
lib/plugins/aws/package/compile/functions.js 96.09% <100.00%> (+0.02%) ⬆️
lib/plugins/aws/package/compile/layers.js 85.41% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6417c...10607fe. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik March 14, 2022 14:43
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one minor question, otherwise it looks great 👍

lib/utils/telemetry/generate-payload.js Show resolved Hide resolved
@medikoo medikoo merged commit fdb5247 into main Mar 14, 2022
@medikoo medikoo deleted the 0311-auto-latest-lambda-extension-resolution branch March 14, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants