fix(AWS Invocation): Ensure proper log formatting for invoke
#11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #11189 +/- ##
=======================================
Coverage 86.01% 86.01%
=======================================
Files 315 315
Lines 13273 13275 +2
=======================================
+ Hits 11417 11419 +2
Misses 1856 1856
Continue to review full report at Codecov.
|
medikoo
reviewed
Jun 29, 2022
lib/plugins/aws/invoke.js
Outdated
| @@ -113,6 +113,14 @@ class AwsInvoke { | |||
| ); | |||
| const logResult = Buffer.from(invocationReply.LogResult, 'base64').toString(); | |||
| logResult.split('\n').forEach((line) => { | |||
| if ( | |||
| // TODO: Switch to .startsWith after otel extension is improved | |||
| line.includes('⚡.') || | |||
There was a problem hiding this comment.
It's long time since we do not issue such logs with extension, so I think it can safely be removed
| @@ -13,7 +13,7 @@ chai.use(require('sinon-chai')); | |||
|
|
|||
| const expect = chai.expect; | |||
|
|
|||
| describe('test/unit/lib/plugins/aws/invoke.test.js', () => { | |||
| describe.only('test/unit/lib/plugins/aws/invoke.test.js', () => { | |||
There was a problem hiding this comment.
Let's not commit this change (ideally it should be picked by linter)
pgrzesik
force-pushed
the
filter-out-logs-in-invoke
branch
from
f363997
to
161fd48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11188