New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AWS Deploy): Handle error for abnormal CloudFormation stack state during AWS deployment #11863
Conversation
… during AWS deployment
…te during AWS deployment
…oudFormation stack state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archepro84 thanks for addressing this. Before we take it, let's clarify few things:
What is the behavior currently (before this change), where exactly we crash, and what exactly is the error we receive?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archepro84, thanks for the additional explanations! Your proposal looks very good, please check my suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions, @medikoo. I have reviewed all of your suggestions and left comments where necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @archepro84 ! We're getting closer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
An error that occurs when Serverless Deploy is forcibly terminated has been corrected.
When the status of the CloudFormation Stack is,
REVIREW_IN_PROGRESS
the code is configured to output an error message as discussed in the issue.Closes: #11852