-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for python3.12 runtime #12300
base: v3
Are you sure you want to change the base?
Conversation
76491bc
to
0fd8d51
Compare
and 3.7 is deprecated |
Hello, will work on merging these changes start anytime soon? |
I know it has been Christmas, but looking at the "blame" info, the Python 3.11 release was proposed on the 26th July and merged on the 27th when AWS made their announcement. Hopefully it's quicker than Python 3.10, which was proposed on 18th April (the same day that it was annouonced) but not merged until 11th May because of vacation time! |
There has been no activity over the master branch since December 6th. I wonder what will happen with Serverless v3 with the plans for v4. |
Is there any update on this PR? |
Hi, could this be merged quickly, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Can someone please approve this pull request quickly? Also, is there anything that is blocking the merge?
Commenting on this to hopefully bump it up. Version 3.12 would be ideal, hopefully can get merged asap. |
Is Serverless still being actively maintained? This (seemingly small and simple PR) has been sitting waiting for attention for a LONG time with many people commenting and no merge, let alone release. |
Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week. |
What's the policy for v3? Shouldn't this fix (as well as support for Java 21, dot.net 8, see respective PRs) be also released as minor v3 version? |
Why does this require a mayor release? |
Simple, Profit 😜 V4 is licensed for profit. V3 isn't. Also I'm guessing the features on V4 are not going to be backwards compatible. since its a reimplementation |
https://www.serverless.com/blog/serverless-framework-v4-a-new-model This blog post is from October last year so it's not news for many, but it is for me. Seems like Serverless v4 is going to require a paid license for anything but the most modest commercial use. That blog post says that v3 will still be maintained with "critical security and bug fixes through 2024". I guess they don't consider supporting up to date Lambda runtimes as a critical security or bug fix. Many would beg to differ. But it's kind of moot given that Serverless won't be a true open source project any longer. I hope someone forks from v3 and keeps it alive. Otherwise, time to pin to v3.latest and start migrating projects to SAM and deal with it's limitations. |
Yep. We have now decided to abandon serverless in the long run. |
Oh wow, thanks. Welcome SAM then 😁 |
Locking a 1 line PR behind v4.x and the licensing change is a bad look. The community should fork this project. |
Anyone forked it already? |
Surely this can be merged now given v4 is available... |
I just made a super simple plugin that allows to override the awsLambdaRuntime value of the validation schema. https://www.npmjs.com/package/serverless-v3-aws-lambda-runtime-schema-override |
@scolebrook why |
Meanwhile adding |
Add support for python 3.12 runtime (announcement)
Closes: #12299