Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for python3.12 runtime #12300

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from

Conversation

LironEr
Copy link

@LironEr LironEr commented Dec 18, 2023

Add support for python 3.12 runtime (announcement)

Closes: #12299

@adminy
Copy link

adminy commented Jan 5, 2024

and 3.7 is deprecated

@DamianCzajkowski
Copy link

Hello, will work on merging these changes start anytime soon?

@StuartBertram
Copy link

I know it has been Christmas, but looking at the "blame" info, the Python 3.11 release was proposed on the 26th July and merged on the 27th when AWS made their announcement.

Hopefully it's quicker than Python 3.10, which was proposed on 18th April (the same day that it was annouonced) but not merged until 11th May because of vacation time!

@FinchPowers
Copy link
Contributor

There has been no activity over the master branch since December 6th. I wonder what will happen with Serverless v3 with the plans for v4.

r3sdev

This comment was marked as off-topic.

@robgagliano
Copy link

Is there any update on this PR?

@mgerlach
Copy link
Contributor

Hi, could this be merged quickly, please?

Copy link

@andrea-bruno-moov andrea-bruno-moov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Can someone please approve this pull request quickly? Also, is there anything that is blocking the merge?

@norvalbv
Copy link

Commenting on this to hopefully bump it up. Version 3.12 would be ideal, hopefully can get merged asap.

@scolebrook
Copy link

Is Serverless still being actively maintained? This (seemingly small and simple PR) has been sitting waiting for attention for a LONG time with many people commenting and no merge, let alone release.

@Mmarzex
Copy link
Contributor

Mmarzex commented Mar 6, 2024

Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week.

@mgerlach
Copy link
Contributor

mgerlach commented Mar 7, 2024

What's the policy for v3? Shouldn't this fix (as well as support for Java 21, dot.net 8, see respective PRs) be also released as minor v3 version?

@max-lobur
Copy link

Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week.

Why does this require a mayor release?

@adminy
Copy link

adminy commented Apr 17, 2024

Simple, Profit 😜 V4 is licensed for profit. V3 isn't. Also I'm guessing the features on V4 are not going to be backwards compatible. since its a reimplementation

@scolebrook
Copy link

Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week.
That "next week" was over 6 weeks ago.

https://www.serverless.com/blog/serverless-framework-v4-a-new-model

This blog post is from October last year so it's not news for many, but it is for me. Seems like Serverless v4 is going to require a paid license for anything but the most modest commercial use. That blog post says that v3 will still be maintained with "critical security and bug fixes through 2024". I guess they don't consider supporting up to date Lambda runtimes as a critical security or bug fix. Many would beg to differ.

But it's kind of moot given that Serverless won't be a true open source project any longer. I hope someone forks from v3 and keeps it alive. Otherwise, time to pin to v3.latest and start migrating projects to SAM and deal with it's limitations.

@mgerlach
Copy link
Contributor

Simple, Profit 😜 V4 is licensed for profit. V3 isn't. Also I'm guessing the features on V4 are not going to be backwards compatible. since its a reimplementation

Yep. We have now decided to abandon serverless in the long run.

@max-lobur
Copy link

Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week.
That "next week" was over 6 weeks ago.

https://www.serverless.com/blog/serverless-framework-v4-a-new-model

This blog post is from October last year so it's not news for many, but it is for me. Seems like Serverless v4 is going to require a paid license for anything but the most modest commercial use. That blog post says that v3 will still be maintained with "critical security and bug fixes through 2024". I guess they don't consider supporting up to date Lambda runtimes as a critical security or bug fix. Many would beg to differ.

But it's kind of moot given that Serverless won't be a true open source project any longer. I hope someone forks from v3 and keeps it alive. Otherwise, time to pin to v3.latest and start migrating projects to SAM and deal with it's limitations.

Oh wow, thanks. Welcome SAM then 😁

@astuyve
Copy link
Contributor

astuyve commented May 22, 2024

Locking a 1 line PR behind v4.x and the licensing change is a bad look. The community should fork this project.

@jimmyn
Copy link

jimmyn commented Jun 18, 2024

Anyone forked it already?

@jameshalsall
Copy link

Surely this can be merged now given v4 is available...

@FinchPowers
Copy link
Contributor

I just made a super simple plugin that allows to override the awsLambdaRuntime value of the validation schema.

https://www.npmjs.com/package/serverless-v3-aws-lambda-runtime-schema-override

It's a single file with no external dependencies.

@manumbs
Copy link

manumbs commented Jun 24, 2024

Sorry everyone, this will be included in the v4 beta that is targeted for availability within the next week.
That "next week" was over 6 weeks ago.

https://www.serverless.com/blog/serverless-framework-v4-a-new-model

This blog post is from October last year so it's not news for many, but it is for me. Seems like Serverless v4 is going to require a paid license for anything but the most modest commercial use. That blog post says that v3 will still be maintained with "critical security and bug fixes through 2024". I guess they don't consider supporting up to date Lambda runtimes as a critical security or bug fix. Many would beg to differ.

But it's kind of moot given that Serverless won't be a true open source project any longer. I hope someone forks from v3 and keeps it alive. Otherwise, time to pin to v3.latest and start migrating projects to SAM and deal with it's limitations.

@scolebrook why java21 is supported in v3 in this PR (merged recently) and python3.12 can't be as well?

@mgerlach
Copy link
Contributor

Meanwhile adding configValidationMode: warn to serverless.yml should work. We use it and are able to set the runtime to Python 3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for python3.12 runtime