Add support for setting API Keys for APIG #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. The only thing which is missing is a documentation (but I think there's already another issue open for this correct?). If that's the case it's GTM from my side. |
|
@pmuens thanks for looking into it. I'll add the docs asap 😊 |
| provider: | ||
| name: aws | ||
| apiKeys: | ||
| - myFirstKey |
There was a problem hiding this comment.
Does it need to be indented that much?
There was a problem hiding this comment.
Nice! you got a good eye for "spaces" xD
There was a problem hiding this comment.
:-D Sorry for being that nasty!
|
Looks great! Thanks for the updates. GTM from my side |
|
GTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for providing API Keys for APIG as described in Issue 1595
Status: G2M from my side