New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stack outputs to verbose info and deploy output #2253
Add Stack outputs to verbose info and deploy output #2253
Conversation
GTM from my side on functionality, @pmuens can you review and if the Code is OK and it works as expected after your review you can merge. |
@@ -88,13 +88,14 @@ class AwsInfo { | |||
return BbPromise.resolve(gatheredData); | |||
}) | |||
.then((gatheredData) => this.getApiKeyValues(gatheredData)) | |||
.then((gatheredData) => BbPromise.resolve(gatheredData.info)) // resolve the info at the end | |||
.then((gatheredData) => BbPromise.resolve(gatheredData)) // resolve the info at the end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update or remove the misleading comment.
@svdgraaf thank you for this PR! Really helpful.
Thank you very much. Once those are done it's good to go from my side. |
@pmuens I think I covered all your requested changes, can you check again? |
Awesome! Thank you very much @svdgraaf 🌮 Merged. Great functionality! |
What did you implement:
_Implementing Issue:_ #2135
How did you implement it:
Changed the info command a bit, now it forwards the full
gatherData
hash instead of just the info part todisplay()
. I also needed to update all the tests.How can we verify it:
As discussed in #2135, this is a PR to add
--verbose
output to theinfo
anddeploy
commands.When adding the
--verbose
command, this will append your Stack Outputs, like so:Todos:
_Is this ready for review?:_ YES