Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stack outputs to verbose info and deploy output #2253

Merged
merged 8 commits into from Oct 13, 2016
Merged

Add Stack outputs to verbose info and deploy output #2253

merged 8 commits into from Oct 13, 2016

Conversation

svdgraaf
Copy link
Contributor

@svdgraaf svdgraaf commented Oct 3, 2016

What did you implement:

_Implementing Issue:_ #2135

How did you implement it:

Changed the info command a bit, now it forwards the full gatherData hash instead of just the info part to display(). I also needed to update all the tests.

How can we verify it:

As discussed in #2135, this is a PR to add --verbose output to the info and deploy commands.

When adding the --verbose command, this will append your Stack Outputs, like so:

screenshot 2016-10-03 12 52 18

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config/commands/resources
  • Change ready for review message below

_Is this ready for review?:_ YES

@flomotlik
Copy link
Contributor

GTM from my side on functionality, @pmuens can you review and if the Code is OK and it works as expected after your review you can merge.

@pmuens pmuens added this to the v1.0-ideas milestone Oct 7, 2016
@@ -88,13 +88,14 @@ class AwsInfo {
return BbPromise.resolve(gatheredData);
})
.then((gatheredData) => this.getApiKeyValues(gatheredData))
.then((gatheredData) => BbPromise.resolve(gatheredData.info)) // resolve the info at the end
.then((gatheredData) => BbPromise.resolve(gatheredData)) // resolve the info at the end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update or remove the misleading comment.

@pmuens
Copy link
Contributor

pmuens commented Oct 7, 2016

@svdgraaf thank you for this PR! Really helpful.

  • Could you please add the verbose option to the core info plugin? (like it's done in the deploy plugin)
  • Could you please add the verbose option at the top of the docs/03-cli-reference/05-info.md file? (like it's done in the deploy readme file)
  • Could you please rebase the branch so that the conflicts are resolved

Thank you very much.

Once those are done it's good to go from my side.

@svdgraaf
Copy link
Contributor Author

@pmuens I think I covered all your requested changes, can you check again?

@pmuens
Copy link
Contributor

pmuens commented Oct 13, 2016

Awesome! Thank you very much @svdgraaf 🌮

Merged. Great functionality!

@pmuens pmuens merged commit 1411fb1 into serverless:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants