Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudWatchEvent rule name and description fields #2910

Merged
merged 5 commits into from Dec 12, 2016
Merged

Add CloudWatchEvent rule name and description fields #2910

merged 5 commits into from Dec 12, 2016

Conversation

horike37
Copy link
Member

What did you implement:

Closes #2832

How did you implement it:

It is possible to add name and description property of scheduled event in CloudFormation.
These are not required properties.

How can we verify it:

set property as follow

 events:
      - schedule:
          name: my-scheduled-event
          description: 'my scheduled event'
          rate: rate(10 minutes)

deployed name and description to a scheduled event Lambda
2016-12-10 13 49 14

Todos:

Linting errors occurs in master branch. But my implementaion is no problem.

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config/commands/resources
  • Enable "Allow edits from maintainers" for this PR
  • Change ready for review message below

Is this ready for review?: YES

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@horike37 thanks for this PR! 👍

Tested it locally and it worked like a charm!
I just merged the current master into this one so that we can get rid of the failing linting test.

GTM from my side!

@horike37
Copy link
Member Author

👍👍👍

@@ -34,6 +34,8 @@ functions:
handler: statistics.handler
events:
- schedule:
name: your-scheduled-rate-event-name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to leave existing examples as they are and add another one with name and description.

Copy link
Contributor

@mthenw mthenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix in docs

- schedule:
name: your-scheduled-rate-event-name
description: 'your scheduled rate event description'
rate(2 hours)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like typo :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@horike37 one more fix and we are good to go :)

@horike37
Copy link
Member Author

@mthenw
Thanks!! fixed it.

@mthenw mthenw merged commit e2f5c06 into serverless:master Dec 12, 2016
@horike37 horike37 deleted the issue-2832 branch December 12, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants