-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudWatchEvent rule name and description fields #2910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@horike37 thanks for this PR! 👍
Tested it locally and it worked like a charm!
I just merged the current master into this one so that we can get rid of the failing linting test.
GTM from my side!
👍👍👍 |
@@ -34,6 +34,8 @@ functions: | |||
handler: statistics.handler | |||
events: | |||
- schedule: | |||
name: your-scheduled-rate-event-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to leave existing examples as they are and add another one with name and description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix in docs
- schedule: | ||
name: your-scheduled-rate-event-name | ||
description: 'your scheduled rate event description' | ||
rate(2 hours) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like typo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@horike37 one more fix and we are good to go :)
@mthenw |
What did you implement:
Closes #2832
How did you implement it:
It is possible to add name and description property of scheduled event in CloudFormation.
These are not required properties.
How can we verify it:
set property as follow
deployed name and description to a scheduled event Lambda
Todos:
Linting errors occurs in master branch. But my implementaion is no problem.
Is this ready for review?: YES