Fix 2404 Receive "Deployment bucket is not in the same region..." when using eu-west-1 #3107
Conversation
There was a problem hiding this comment.
Hey @ssemyonov thank you for this PR! 👍
I tried to reproduce #2404 but was unsuccessful to do so. I checked out your PR and was able to deploy to eu-west-1 w/o problems.
Don't know if @eahefnawy can reproduce this.
I'm fine with merging it since it seems to resolve the issue and is one line of code which won't break anything. Although unfortunately I cannot confirm that it fixes the issue mentioned in #2404.
|
|
||
| awsPlugin.options.region = value.region; | ||
|
|
||
| sinon |
There was a problem hiding this comment.
This stub should be restored.
There was a problem hiding this comment.
awsPlugin.provider.request.restore(); added below
|
Yeah this is hard to reproduce as it depends on what AWS might return. Considering the change is a simple if statement, I see no harm in merging without testing it out just like @pmuens mentioned. |
|
@ssemyonov thanks for the update! Merging... |
|
cheers |
|
@pmuens I assume this fix will be released in Serverless 1.6? Don't see it in the milestone 1.6. |
|
@nick4eva Yes, this one will be released in 1.6 (maybe even in 1.5.1 which is planned for the end of this week)! Will add it to the 1.6 milestone... |
What did you implement:
Closes #2404
How did you implement it:
Similar to original #2404 fix for us-east-1:
if (result.LocationConstraint === 'EU') result.LocationConstraint = 'eu-west-1';How can we verify it:
By deploying using pre-existing bucket in eu-west-1 region in one of the affected AWS accounts (which might be tricky to find).
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO