Extend OpenWhisk Runtime Support #3454
Conversation
|
Thanks @jthomas 👍 Will be reviewed ASAP! |
| This example will generate scaffolding for a service with `openwhisk` as a provider and `nodejs` as runtime. The scaffolding | ||
| will be generated in the `my-new-service` directory. This directory will be created if not present. Otherwise Serverless | ||
| will use the already present directory. | ||
| This example will generate scaffolding for a service with `openwhisk` as a provider and `nodejs` as runtime. The scaffolding will be generated in the `my-new-service` directory. This directory will be created if not present. Otherwise Serverless will use the already present directory. |
There was a problem hiding this comment.
Which is a correct one? Line 56 says nodejs:6 runtime and line 66 says just nodejs runtime. But commands look same
There was a problem hiding this comment.
Either works, you can just use nodejs for the default version or add an explicit version tag.
| @@ -18,6 +18,8 @@ This runs your code locally by emulating the Apache OpenWhisk environment. Pleas | |||
| serverless invoke local --function functionName | |||
| ``` | |||
|
|
|||
| __*Please note that only the JavaScript and Python runtimes are supported with this command.*__ | |||
|
|
|||
There was a problem hiding this comment.
So how is the runtime called? JavaScript runtime (line 21) or NodeJs runtime (line 65) ?
There was a problem hiding this comment.
I can change this to be "Node.js" but I assume most people will understand what this refers too?
| | :--------------------------------------- | :------ | | ||
| | [OpenWhisk Node Simple](https://github.com/serverless/examples/tree/master/openwhisk-node-simple) <br/> Boilerplate project repository for OpenWhisk provider with Serverless Framework. | nodeJS | | ||
| | [OpenWhisk Python Simple](https://github.com/serverless/examples/tree/master/openwhisk-python-simple) <br/> Boilerplate project repository for OpenWhisk provider with Serverless Framework. | python | | ||
| | [OpenWhisk Swift Simple](https://github.com/serverless/examples/tree/master/openwhisk-swift-simple) <br/> Boilerplate project repository for OpenWhisk provider with Serverless Framework. | swift | | ||
|
|
There was a problem hiding this comment.
Should we mention versions of runtimes here?
There was a problem hiding this comment.
It's not mentioned for the other projects.
There was a problem hiding this comment.
Thanks for the update @jthomas 👍
and thanks @vladgolubev for your review!
Really like how the OpenWhisk provider plugin adds more and more functionality! 💯
I just pushed a minor fix and will merge once the build succeeds. 
|
🎉 🎉 🎉 Thanks for the quick turn around on this! |
What did you implement:
New version (0.6) of the OpenWhisk plugin will include support for non-Node.js runtimes. I have added templates to the
createplugin and also updated the documentation with new features.How did you implement it:
Trivial changes to the
createplugin for the new templates. Docs updated based upon the new features.How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO