Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #3038
Fixes the race condition bug where S3 events randomly fail while deploying the service.
How did you implement it:
Added a
DependsOn
declaration which contains the buckets permission. This ensures that the permission is in place before the bucket is created.How can we verify it:
Just deploy a service like the following:
or run the S3 (complex) integration tests. They should stop failing now.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO