Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 event race condition bug #3705

Merged
merged 1 commit into from Jun 5, 2017
Merged

Conversation

pmuens
Copy link
Contributor

@pmuens pmuens commented May 30, 2017

What did you implement:

Closes #3038

Fixes the race condition bug where S3 events randomly fail while deploying the service.

How did you implement it:

Added a DependsOn declaration which contains the buckets permission. This ensures that the permission is in place before the bucket is created.

How can we verify it:

Just deploy a service like the following:

service: service

provider:
  name: aws
  runtime: nodejs6.10

functions:
  hello:
    handler: handler.hello
    events:
      - s3: some.random.bucket.name

or run the S3 (complex) integration tests. They should stop failing now.

Todos:

  • Write tests
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added this to the 1.15 milestone May 30, 2017
Copy link
Member

@eahefnawy eahefnawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! G2M 👍

@eahefnawy eahefnawy merged commit 0997b32 into master Jun 5, 2017
@pmuens pmuens deleted the fix-s3-event-race-condition-bug branch June 5, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants