Update serverless.yml.md #5236
Merged
Update serverless.yml.md #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In https://serverless.com/framework/docs/providers/aws/guide/deploying/ the documentation states that you can deploy to different environments / regions by passing them to the --stage or --region flags, however this doesn't work out of the box because the sample documentation / serverless.yml file hardcodes the stage & region and is not set up to use the ones passed to the CLI.
horike37
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
@khaledosman
Thank you for improving this!
I think this PR makes easier to understand how to use those options. Agreed 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://serverless.com/framework/docs/providers/aws/guide/deploying/ the documentation states that you can deploy to different environments / regions by passing them to the --stage or --region flags, however this doesn't work out of the box because the sample documentation / serverless.yml file hardcodes the stage & region and is not set up to use the ones passed to the CLI.
Is this ready for review?: YES
Is it a breaking change?: NO