Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid log #5377

Merged
merged 1 commit into from Oct 13, 2018
Merged

Remove invalid log #5377

merged 1 commit into from Oct 13, 2018

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 11, 2018

When running one of the SLS commands I spotted wierd log Serverless: INVOKING INVOKE

screen shot 2018-10-11 at 15 26 37

It feels as something committed in by mistake

Is this ready for review?: YES
Is it a breaking change?: NO

/cc @lewisf

@medikoo
Copy link
Contributor Author

medikoo commented Oct 11, 2018

Coverage fail should be ignored, as clearly percentage dropped just because one working (and previously covered) line of code has been removed

horike37
horike37 approved these changes Oct 13, 2018
View reviewed changes
Copy link
Member

@horike37 horike37 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe you are right.
When running sls invoke, it returns only response, so sls invoke local should be a same behavior.
See related issue: #2620

@horike37 horike37 added this to the 1.33.0 milestone Oct 13, 2018
@horike37 horike37 merged commit 713a584 into serverless:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horike37 horike37 horike37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@medikoo @horike37