Don't use py3.5+ only subprocess.run in python invoke local #5500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fixes #5499
invoke local was changed in #5355 to check for a tty by calling the
tty
executable, but it was implemented withsubprocess.run
which was added in Python 3.5 so it doesn't work with Python 2.7 projectsHow did you implement it:
Switched to the older
subprocess.check_call
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO