Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use py3.5+ only subprocess.run in python invoke local #5500

Merged
merged 1 commit into from Nov 19, 2018

Conversation

@dschep
Copy link
Contributor

dschep commented Nov 16, 2018

What did you implement:

Fixes #5499

invoke local was changed in #5355 to check for a tty by calling the tty executable, but it was implemented with subprocess.run which was added in Python 3.5 so it doesn't work with Python 2.7 projects

How did you implement it:

Switched to the older subprocess.check_call

How can we verify it:

npm i -g serverless/serverless#fix-py27-invoke-local
sls create -t aws-python
sls invoke local -f hello

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@dschep dschep requested a review from alexdebrie Nov 16, 2018
@dschep

This comment has been minimized.

Copy link
Contributor Author

dschep commented Nov 16, 2018

@filanthropic mind testing this in the project you ran into #5499? Install as indicated in the PR description ☝️

Copy link
Contributor

alexdebrie left a comment

LGTM. Tested sls invoke local with 1.33.1 and I got the error. Ran with this branch, and sls invoke local worked successfully.

@dschep dschep merged commit 3033540 into master Nov 19, 2018
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on fix-py27-invoke-local at 91.119%
Details
@dschep dschep deleted the fix-py27-invoke-local branch Nov 19, 2018
dschep added a commit that referenced this pull request Nov 19, 2018
dschep added a commit that referenced this pull request Nov 19, 2018
version bump for #5500 and #5503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.