New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update layers.md #5678

Merged

dschep merged 1 commit into serverless:master from timporter:fixInvalidYamlInAWSLayersDoc

Jan 11, 2019

Contributor

timporter commented Jan 11, 2019 •

edited

What did you implement:

Closes #XXXXX

There was broken YAML in the docs

How did you implement it:

Removed YAML value from where it shouldn't have been

How can we verify it:

You can put the existing YAML section into a validator, it will complain that its broken. Even in the subsequent examples the broken part is fixed.

Todos:

Write tests
Write documentation
Fix linting errors
Make sure code coverage hasn't dropped
Provide verification config / commands / resources
Enable "Allow edits from maintainers" for this PR
Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: NO


          Update layers.md

cdf37a6

dschep reviewed

View reviewed changes

Contributor

dschep left a comment

good catch. Thanks @timporter

dschep approved these changes

View reviewed changes

dschep merged commit 3bfcd0a into serverless:master

timporter deleted the fixInvalidYamlInAWSLayersDoc branch

January 11, 2019 13:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment