Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added layer option for deploy function update-config #5787

Merged
merged 2 commits into from Feb 7, 2019

Conversation

Projects
3 participants
@Kivol
Copy link
Contributor

Kivol commented Feb 4, 2019

What did you implement:

Closes #5786

How did you implement it:

Added the processing code for layer option, and the corresponding test and validations

How can we verify it:

I've verified myself that this layer update config works fine.
2019-02-05 2 35 09

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Kivol added some commits Feb 4, 2019

@pmuens pmuens added the pr/in-review label Feb 5, 2019

@pmuens

pmuens approved these changes Feb 5, 2019

Copy link
Member

pmuens left a comment

Great! Thanks for working on this @Kivol 👍

Just tested it today and it works as expected. LGTM :shipit:

Here's the config I used to test it:

service: test

provider:
  name: aws
  runtime: provided

functions:
  hello:
    handler: handler.hello
    layers:
      - arn:aws:lambda:us-east-1:553035198032:layer:nodejs11:8
      # - arn:aws:lambda:us-east-1:553035198032:layer:nodejs10:3

@pmuens pmuens added this to In progress in Serverless via automation Feb 5, 2019

@pmuens pmuens self-assigned this Feb 5, 2019

@pmuens pmuens merged commit 6a4dc2b into serverless:master Feb 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Serverless automation moved this from In progress to Done Feb 7, 2019

@pmuens pmuens added this to the 1.38.0 milestone Feb 7, 2019

@vaibhav3patil

This comment has been minimized.

Copy link

vaibhav3patil commented Feb 25, 2019

Can we adding the functionality that could point to the latest layer by default ?
giving version number in ARN can be some manual work if deploy a new version of lambda layer, or how I can refer the latest version fo lambda layer in serverless even if creating new version I do not want to change in my serverless.yml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.