Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.md #6138

Merged
merged 1 commit into from
May 15, 2019
Merged

Update services.md #6138

merged 1 commit into from
May 15, 2019

Conversation

stripedpajamas
Copy link
Contributor

Removed the paragraph about multiple services behind a shared API gateway

What did you implement:

Removed an inaccurate paragraph from the documentation. Since the referenced issue is closed, I think the removed paragraph is confusing and should not be there.

How did you implement it:

I deleted some text.

How can we verify it:

You can confirm that the removed paragraph is not supposed to be there.

Todos:

  • Write tests (n/a)
  • Write documentation
  • Fix linting errors (n/a)
  • Make sure code coverage hasn't dropped (n/a)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Removed the paragraph about multiple services behind a shared API gateway
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stripedpajamas 👍 LGTM :shipit:

@pmuens pmuens merged commit 2e97bdc into serverless:master May 15, 2019
@medikoo medikoo removed this from the 1.45.0 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants