Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsbeautify configuration #6309

Merged
merged 1 commit into from Jun 27, 2019
Merged

Remove jsbeautify configuration #6309

merged 1 commit into from Jun 27, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jun 26, 2019

Looks as some old artifact, added in 2015, when work on v1 started, and I take no recent code really complied to that. JSBeautifier was not configured in anyway into our project (neither scripts or CI integration was existing)

It's obsolete now, also because we have now working Prettier integration

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo medikoo added this to the 1.47.0 milestone Jun 26, 2019
@medikoo medikoo self-assigned this Jun 26, 2019
@medikoo medikoo requested a review from pmuens June 26, 2019 12:50
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit 2b28203 into master Jun 27, 2019
@medikoo medikoo deleted the remove-jsbeautify-config branch June 27, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants