Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jsbeautify configuration #6309

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
2 participants
@medikoo
Copy link
Member

commented Jun 26, 2019

Looks as some old artifact, added in 2015, when work on v1 started, and I take no recent code really complied to that. JSBeautifier was not configured in anyway into our project (neither scripts or CI integration was existing)

It's obsolete now, also because we have now working Prettier integration

Is this ready for review?: YES
Is it a breaking change?: NO

@medikoo medikoo added this to the 1.47.0 milestone Jun 26, 2019

@medikoo medikoo self-assigned this Jun 26, 2019

@medikoo medikoo added this to In progress in Serverless via automation Jun 26, 2019

@medikoo medikoo added pr/in-review and removed pr/in-progress labels Jun 26, 2019

@medikoo medikoo requested a review from pmuens Jun 26, 2019

@pmuens

pmuens approved these changes Jun 27, 2019

Copy link
Member

left a comment

LGTM :shipit:

Serverless automation moved this from In progress to Reviewer approved Jun 27, 2019

@medikoo medikoo merged commit 2b28203 into master Jun 27, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (medikoo) No manifest changes detected

Serverless automation moved this from Reviewer approved to Done Jun 27, 2019

@medikoo medikoo deleted the remove-jsbeautify-config branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.