Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mock integration documentation example #6883

Merged
merged 2 commits into from Oct 25, 2019
Merged

Added mock integration documentation example #6883

merged 2 commits into from Oct 25, 2019

Conversation

resmall
Copy link
Contributor

@resmall resmall commented Oct 25, 2019

What did you implement

Added documentation for mock integrations, regarding AWS API Gateway events.

Closes #5960

How can we verify it

Reading the documentation, added a simple mock example.

  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens added this to the 1.56.0 milestone Oct 25, 2019
pmuens
pmuens approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating @resmall 👍

LGTM :shipit:

@pmuens pmuens merged commit 56f3c56 into serverless:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees
No one assigned
Labels
cat/aws-event-api-gateway documentation
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

Doc Request: Working example of MOCK integration
2 participants
@resmall @pmuens