New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tencent provider create-template #6898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anycodes Thank you, looks good! Before we merge just wanted to clarify on few things (see comments)
@@ -0,0 +1,6 @@ | |||
# package directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js v6 is already at EOL. Do you feel there's a value in providing template for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have updated the template.
"author": "cloud.tencent.com", | ||
"license": "MIT", | ||
"devDependencies": { | ||
"serverless-tencent-scf": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be good to pin it to current version so ^0.1.7
. That will prevent any eventual breaking changes to a plugin to affect the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I have added the plugin version in package.json just now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this @anycodes 👍
Overall this looks good. I only have some points we might want to discuss before merging this into master
:
- Should we add tests to ensure that all the necessary files are created? Such tests can be found in
create.test.js
(/cc @medikoo) - Should we only include one runtime such as
tencent-python
which creates a template for the most recent version and add a comment in the template itself that the user can also use e.g.Python3.6
? This way we only need to introduce one template per runtime and don't need to append the version in the template name - Do we want to omit Node 6 and Python 2 since they're deprecated / will be deprecated soon? (as @medikoo mentioned above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you @anycodes
@anycodes just noticed, there are some style issues. Can you run |
DFOUNDERLIU-MB0:serverless dfounderliu$ npm run prettify-updated
lib/plugins/create/create.js 135ms |
What did you implement
Add Tencent provider create-template
How can we verify it
cd tencent-python3
and create credentialsvim ~/credentials
, input your secretId, secretKey, appid:sls deploy