PLAT-1798 - set env vars for AWS creds from cached credentials… #6938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement
Allows for use of credentials provided by a deploy profile in the
serverless dashboard
Closes PLAT-1798
How can we verify it
on a system with no credentials, set up a project using serverless dashbaord with an access role in your deploy profile. then create a project with
sls create -t aws-nodejs
then replace thehandler.js
withand configure your app/org in
serverless.yml
with the respective values from your dashboard config.then install this branch and invoke
it should work. on master it should fail due to lack of creds
Todos
Useful Scripts
npm run test-ci
--> Run all validation checks on proposed changesnpm run lint-updated
--> Lint all the updated filesnpm run lint:fix
--> Automatically fix lint problems (if possible)npm run prettier-check-updated
--> Check if updated files adhere to Prettier confignpm run prettify-updated
--> Prettify all the updated filesIs this ready for review?: YES
Is it a breaking change?: NO