Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API Gateway tagging to use partition for deployed region #6948

Merged
merged 3 commits into from
Nov 13, 2019

Conversation

maafk
Copy link
Contributor

@maafk maafk commented Nov 8, 2019

What did you implement

Updated the section for adding tags to API gateway resources to use whatever partition the user is deploying from, rather than only checking whether commercial or govcloud

Closes #6925

How can we verify it

provider:
  name: aws
  stage: ${opt:stage, 'dev'}
  region: cn-northwest-1
  memorySize: 128
  timeout: 15
  # ...
  tags:
    foo: 'bar'

functions:
  hello-world:
    handler: functions/hello-world.handler
    runtime: nodejs10.x
    endpointType: regional
    events:
      - http:
          path: /
          method: GET
          cors: true

Todos

Useful Scripts
  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@maafk maafk changed the title Update apigateway tagging to use partition for deployed region. fixes #6925 Update API Gateway tagging to use partition for deployed region Nov 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #6948 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6948   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files         229      229           
  Lines        8394     8394           
=======================================
  Hits         7426     7426           
  Misses        968      968
Impacted Files Coverage Δ
.../compile/events/apiGateway/lib/hack/updateStage.js 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedd0fc...59822e4. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @maafk! Thank you

@medikoo medikoo merged commit b631f53 into serverless:master Nov 13, 2019
@ghost
Copy link

ghost commented Nov 13, 2019

Amazing @maafk, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS unable to use tags with custom partition name aws-cn
4 participants