Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3.8 support! #6978

Merged
merged 2 commits into from Nov 20, 2019
Merged

Python3.8 support! #6978

merged 2 commits into from Nov 20, 2019

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Nov 19, 2019

What did you implement

Updated serverless.yml template for aws-python3 to use python3.8.

https://aws.amazon.com/jp/blogs/compute/python-3-8-runtime-now-available-in-aws-lambda/

Closes #XXXXX

How can we verify it

Todos

Useful Scripts
  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #6978 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6978   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         229      229           
  Lines        8416     8416           
=======================================
  Hits         7442     7442           
  Misses        974      974
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 76.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33ee52...afab412. Read the comment docs.

medikoo
medikoo previously approved these changes Nov 20, 2019
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kdnakt !

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added also documentation updates.

@medikoo medikoo added this to the 1.58.0 milestone Nov 20, 2019
@medikoo medikoo merged commit 821a560 into serverless:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants