AWS HTTP API: Ensure function timeout setting is respected

[medikoo]

Additionally deprecate (by not documenting) a timeout setting on HTTP API endpoint.
As HTTP API endpoints can only be configured through functions, it seems logical to treat function timeout setting as the only source of truth.

Should be considered as bug fix.

[Nemo64]

deprecation by not documenting seems really dangerous. How would anyone notice who is already using that option?

Either don't deprecate, leave the documentation and say that the default value is based on the lambda function timeout or print a warning so that everyone using it knows that this option may be dropped in the next mayor release.

I would tend to leave the option.

[medikoo]

deprecation by not documenting seems really dangerous. How would anyone notice who is already using that option?

Good point. I've added deprecation log.

[codecov-io]

Codecov Report

Merging #7420 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #7420      +/-   ##
==========================================
+ Coverage   87.99%   87.99%   +<.01%     
==========================================
  Files         240      240              
  Lines        9052     9063      +11     
==========================================
+ Hits         7965     7975      +10     
- Misses       1087     1088       +1

Impacted Files	Coverage Δ
...lugins/aws/package/compile/events/httpApi/index.js	88.6% <90.9%> (+0.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba84179...306710a. Read the comment docs.

[eahefnawy]

Looks good @medikoo 👌

Just to be sure though, users are still able to configure HTTP APIs timeout, it's just that we compare that to the function timeout , correct?

[medikoo]

Just to be sure though, users are still able to configure HTTP APIs timeout, it's just that we compare that to the function timeout , correct?

Yes, I left ability to configure timeout on httpApi event but it's now deprecated to do so. Users should just follow settings on lambda (I think there's no valid use case to provide two different timeouts for lambda and HTTP endpoint)