Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event bridge schema validation #8114

Merged
merged 1 commit into from Aug 21, 2020

Conversation

fredericbarthelet
Copy link
Contributor

Closes: #8029

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #8114 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8114      +/-   ##
==========================================
- Coverage   88.30%   88.28%   -0.03%     
==========================================
  Files         248      248              
  Lines        9451     9432      -19     
==========================================
- Hits         8346     8327      -19     
  Misses       1105     1105              
Impacted Files Coverage Δ
...ns/aws/package/compile/events/eventBridge/index.js 100.00% <100.00%> (ø)
lib/plugins/aws/customResources/generateZip.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0938c7...a41b487. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @fredericbarthelet, I've picked few typos though

@fredericbarthelet
Copy link
Contributor Author

@medikoo sorry for the typos, PR updated :)

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fredericbarthelet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config schema: Define AWS "eventBridge" function event properties
3 participants