CLI: Seclude version output functionality out of CLI class #8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
0108-cli-version
branch
from
7f2e5af
to
cc67f67
Compare
Codecov Report
@@ Coverage Diff @@
## master #8741 +/- ##
=======================================
Coverage 87.43% 87.44%
=======================================
Files 256 257 +1
Lines 9631 9630 -1
=======================================
Hits 8421 8421
+ Misses 1210 1209 -1
Continue to review full report at Codecov.
|
pgrzesik
suggested changes
Jan 11, 2021
lib/cli/eventually-list-version.js
Outdated
|
|
||
| const userNodeVersion = Number(process.version.split('.')[0].slice(1)); | ||
| // only show components version if user is running Node 8+ | ||
| if (userNodeVersion >= 8) { |
There was a problem hiding this comment.
I believe this check is redundant as we require node>=10 now
There was a problem hiding this comment.
Good find, thanks for pointing!
medikoo
force-pushed
the
0108-cli-version
branch
from
cc67f67
to
6a091e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 1.0 from #8364