Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Templates): Compilation target ES2019 in aws-nodejs-typescript #8774

Merged

Conversation

fredericbarthelet
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #8774 (c967ad6) into master (a364865) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8774      +/-   ##
==========================================
+ Coverage   87.58%   87.70%   +0.12%     
==========================================
  Files         260      262       +2     
  Lines        9664     9763      +99     
==========================================
+ Hits         8464     8563      +99     
  Misses       1200     1200              
Impacted Files Coverage Δ
lib/plugins/aws/deploy/index.js 96.36% <0.00%> (-0.19%) ⬇️
lib/plugins/aws/package/compile/functions.js 96.02% <0.00%> (-0.17%) ⬇️
lib/plugins/aws/remove/index.js 100.00% <0.00%> (ø)
lib/plugins/aws/lib/checkIfEcrRepositoryExists.js 88.88% <0.00%> (ø)
lib/plugins/aws/remove/lib/ecr.js 100.00% <0.00%> (ø)
lib/plugins/aws/lib/naming.js 97.63% <0.00%> (+0.04%) ⬆️
lib/classes/Service.js 86.40% <0.00%> (+0.80%) ⬆️
lib/plugins/aws/deployFunction.js 95.86% <0.00%> (+0.86%) ⬆️
lib/plugins/aws/provider.js 94.50% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a364865...c967ad6. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@pgrzesik pgrzesik changed the title Update TS template compilation target to ES2019 fix(Templates): Compilation target ES2019 in aws-nodejs-typescript Jan 18, 2021
@pgrzesik pgrzesik merged commit 4469388 into serverless:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants