Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ajv to v7 #8779

Closed
wants to merge 3 commits into from
Closed

Upgrade ajv to v7 #8779

wants to merge 3 commits into from

Conversation

pgrzesik
Copy link
Contributor

@pgrzesik pgrzesik commented Jan 18, 2021

Addresses #8695

This PR aims to bring ajv v7 upgrade whenever we feel it's good time for it. In includes two commits that were reverted with https://github.com/serverless/serverless/commits/master as well as picks up the work that was done as a part of #8742.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #8779 (5d2b332) into master (b23bfdb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8779      +/-   ##
==========================================
+ Coverage   87.74%   87.75%   +0.01%     
==========================================
  Files         264      264              
  Lines        9780     9778       -2     
==========================================
  Hits         8581     8581              
+ Misses       1199     1197       -2     
Impacted Files Coverage Δ
lib/Serverless.js 97.36% <100.00%> (ø)
lib/classes/ConfigSchemaHandler/index.js 91.25% <100.00%> (-0.11%) ⬇️
.../classes/ConfigSchemaHandler/normalizeAjvErrors.js 95.72% <100.00%> (-0.08%) ⬇️
.../classes/ConfigSchemaHandler/resolveAjvValidate.js 100.00% <100.00%> (ø)
lib/classes/Service.js 86.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23bfdb...5d2b332. Read the comment docs.

@mnapoli
Copy link
Contributor

mnapoli commented Jan 14, 2022

Following #10440 we can probably close this one?

@pgrzesik
Copy link
Contributor Author

Definitely @mnapoli

@pgrzesik pgrzesik closed this Jan 14, 2022
@medikoo medikoo deleted the upgrade-ajv-to-v7 branch May 19, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants