Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove bluebird from test/unit/lib/classes #9070

Conversation

juanjoDiaz
Copy link
Contributor

Addresses: #7171

@juanjoDiaz juanjoDiaz force-pushed the remove_bluebird_test_unit_lib_classes branch from 60f4a4a to d6f5a31 Compare March 3, 2021 22:35
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #9070 (a3c22fb) into master (ccba70a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9070   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files         288      288           
  Lines       11026    11026           
=======================================
  Hits         9610     9610           
  Misses       1416     1416           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccba70a...d6f5a31. Read the comment docs.

@pgrzesik
Copy link
Contributor

Thanks once again @juanjoDiaz - as mentioned in related PR, we'd like to follow more iterative, small-steps path - I'm going to close this PR for now.

@pgrzesik pgrzesik closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants