New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Config Schema): Accept accountId
as policy principal
#9082
feat(Config Schema): Accept accountId
as policy principal
#9082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9082 +/- ##
==========================================
- Coverage 87.17% 87.15% -0.02%
==========================================
Files 288 289 +1
Lines 11068 11077 +9
==========================================
+ Hits 9648 9654 +6
- Misses 1420 1423 +3
Continue to review full report at Codecov.
|
Modified it to allow mixed types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 I've just added one small comment and we should be good to go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you @blue-urban-sky 🙇
accountId
as policy principal
Issue around using
causing a schema validation warning
I have added
#/definitions/awsAccountId
and updatedawsIamPolicyPrincipal
to include it as a possible optionCloses: #9077