Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS CloudFront: Recognize "?" character in pathPattern property #9234

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Apr 2, 2021

Closes: #9228

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #9234 (2f86b5a) into master (7d16947) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2f86b5a differs from pull request most recent head 264b35f. Consider uploading reports for the commit 264b35f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9234   +/-   ##
=======================================
  Coverage   86.95%   86.96%           
=======================================
  Files         315      315           
  Lines       11708    11707    -1     
=======================================
  Hits        10181    10181           
+ Misses       1527     1526    -1     
Impacted Files Coverage Δ
lib/classes/Variables.js 99.73% <ø> (ø)
lib/cli/commands-schema/aws-service.js 100.00% <ø> (ø)
...aws/package/compile/events/apiGateway/lib/stage.js 100.00% <ø> (ø)
...b/plugins/aws/package/compile/events/cloudFront.js 98.90% <ø> (ø)
...s/create/templates/aws-nodejs-ecma-script/first.js 0.00% <ø> (ø)
.../create/templates/aws-nodejs-ecma-script/second.js 0.00% <ø> (ø)
...templates/aws-nodejs-ecma-script/webpack.config.js 0.00% <ø> (ø)
lib/utils/log/log.js 0.00% <ø> (ø)
lib/classes/CLI.js 100.00% <100.00%> (ø)
lib/classes/Error.js 95.45% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d16947...264b35f. Read the comment docs.

@medikoo medikoo merged commit 9d84596 into master Apr 2, 2021
@medikoo medikoo deleted the 0402-cloudfront-fix-path-pattern branch April 2, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for a "Configuration warning" relating CloudFront's path pattern
1 participant