Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix help output when provider.name is missing #9235

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Apr 2, 2021

When sls --help is run in context of service which does not have set provider.name. The error about property being missing is shown instead of help output.

This patch fixes that

@medikoo medikoo self-assigned this Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #9235 (cb534c0) into master (ae67bf4) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

❗ Current head cb534c0 differs from pull request most recent head 9b9bc24. Consider uploading reports for the commit 9b9bc24 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9235      +/-   ##
==========================================
- Coverage   86.96%   86.94%   -0.02%     
==========================================
  Files         315      315              
  Lines       11707    11720      +13     
==========================================
+ Hits        10181    10190       +9     
- Misses       1526     1530       +4     
Impacted Files Coverage Δ
scripts/serverless.js 49.78% <33.33%> (+0.22%) ⬆️
lib/configuration/resolve-provider-name.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae67bf4...9b9bc24. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik April 2, 2021 15:37
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@medikoo medikoo merged commit dae9058 into master Apr 6, 2021
@medikoo medikoo deleted the 0402-fix-help-output branch April 6, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants