fix(AWS Deploy): Correctly identify "no updates" error during deploy #9248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9248 +/- ##
==========================================
- Coverage 86.96% 86.94% -0.02%
==========================================
Files 315 315
Lines 11707 11721 +14
==========================================
+ Hits 10181 10191 +10
- Misses 1526 1530 +4
Continue to review full report at Codecov.
|
medikoo
reviewed
Apr 6, 2021
lib/plugins/aws/lib/updateStack.js
Outdated
| const cfData = await this.provider.request('CloudFormation', 'updateStack', params); | ||
| await this.monitorStack('update', cfData); | ||
| } catch (e) { | ||
| if (!e.message.includes(NO_UPDATE_MESSAGE)) { |
There was a problem hiding this comment.
I think this error may happen only on CloudFormation.updateStack call right?
In such case, I'd wrap with try/catch only provider.request invocation.
There was a problem hiding this comment.
good catch - that's correct 👍
pgrzesik
force-pushed
the
correctly-identify-no-updates-aws-error-during-deployment-without-changes
branch
from
71ac694
to
440deb7
Compare
pgrzesik
force-pushed
the
correctly-identify-no-updates-aws-error-during-deployment-without-changes
branch
from
440deb7
to
5e55e29
Compare
pgrzesik
deleted the
correctly-identify-no-updates-aws-error-during-deployment-without-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9241