Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Ensure config.servicePath works as an alias for `config.s… #9343

Merged
merged 1 commit into from Apr 21, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Apr 21, 2021

Some plugins override config.servicePath, and after recent changes this property is not read in Framework internalls.

This patch ensures that config.servicePath serves as live alias of serviceDir

@medikoo medikoo self-assigned this Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #9343 (2349c54) into master (aa89357) will increase coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head 2349c54 differs from pull request most recent head fcf9a78. Consider uploading reports for the commit fcf9a78 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9343   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files         316      316           
  Lines       11832    11833    +1     
=======================================
+ Hits        10287    10288    +1     
  Misses       1545     1545           
Impacted Files Coverage Δ
lib/plugins/create/create.js 89.18% <ø> (-0.15%) ⬇️
lib/Serverless.js 91.30% <66.66%> (ø)
lib/classes/Config.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa89357...fcf9a78. Read the comment docs.

@medikoo medikoo force-pushed the 0421-fix-config-service-dir branch from 53d7589 to 21b0c63 Compare April 21, 2021 14:52
@medikoo medikoo force-pushed the 0421-fix-config-service-dir branch from 21b0c63 to fcf9a78 Compare April 21, 2021 14:56
@medikoo medikoo requested a review from pgrzesik April 21, 2021 15:03
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 2967065 into master Apr 21, 2021
@medikoo medikoo deleted the 0421-fix-config-service-dir branch April 21, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants