CLI: Fix issues related to local version fallback #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue for global to local fallback case, where older global which send cache on every command was sending same telemetry as local
medikoo
force-pushed
the
0504-fix-payload-generation
branch
from
6a548f6
to
37dd0cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #9429 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 321 321
Lines 11968 11968
=======================================
Hits 10401 10401
Misses 1567 1567
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9428
Additionally changed the name of the cache folder for telemetry payload. This may introduce slight friction where after upgrade some stored payload will no longer be send (as new version will look into new version).
Still I assume that loss will be negligible, and renaming of a folder is the only way to fix the issue, where old global sends all cached payload on any command and local fallback send same with
sls deploy